Fix cross-compilation support for gz-msg10 #392
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #390
Summary
This PR adds a way to cross-compile gz-msgs10. This is done by defining three CMake options to overload all the executable involved in the message generation process. The workflow is documented with a comment in the CMakeLists.txt (the basic idea is that if you need to cross-compile, probably you know that you know how to read basic code). The main difference w.r.t. to the past is that now code generation happens also in some downstream projects, so this variables need to be set also in downstream projects to cross-compile the downstream projects.
I am not super happy about this solution as it adds a lot of CMake argument parsing boilerplate, but it seem to be working fine and I do not have any concrete idea on how to improve , so I thought it made sense to submit it in this form.
Related past PRs:
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.