Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cross-compilation support for gz-msg10 #392

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Oct 2, 2023

🦟 Bug fix

Fixes #390

Summary

This PR adds a way to cross-compile gz-msgs10. This is done by defining three CMake options to overload all the executable involved in the message generation process. The workflow is documented with a comment in the CMakeLists.txt (the basic idea is that if you need to cross-compile, probably you know that you know how to read basic code). The main difference w.r.t. to the past is that now code generation happens also in some downstream projects, so this variables need to be set also in downstream projects to cross-compile the downstream projects.

I am not super happy about this solution as it adds a lot of CMake argument parsing boilerplate, but it seem to be working fine and I do not have any concrete idea on how to improve , so I thought it made sense to submit it in this form.

Related past PRs:

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Silvio Traversaro <silvio.traversaro@iit.it>
@traversaro traversaro requested a review from caguero as a code owner October 2, 2023 21:07
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Oct 2, 2023
@traversaro traversaro force-pushed the gzmsgs10crosscompilation branch from aa1bfaa to b9302c3 Compare October 2, 2023 21:08
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #392 (e22b64a) into gz-msgs10 (0f69062) will not change coverage.
The diff coverage is n/a.

❗ Current head e22b64a differs from pull request most recent head bf628d2. Consider uploading reports for the commit bf628d2 to get more accurate results

@@            Coverage Diff             @@
##           gz-msgs10     #392   +/-   ##
==========================================
  Coverage      97.26%   97.26%           
==========================================
  Files             27       27           
  Lines           1170     1170           
==========================================
  Hits            1138     1138           
  Misses            32       32           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants