Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not redefine GZ_PYTHON_INSTALL_PATH if it is already defined #393

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Oct 4, 2023

🎉 New feature

Summary

When doing packaging, it is sometimes useful for advanced users to just tell the build system where to install Python files, without any sort of auto-detection. This was already supported elsewhere (see

if (NOT GZ_PYTHON_INSTALL_PATH)
and https://github.com/gazebosim/gz-msgs/blob/gz-msgs10/cmake/gz_msgs_generate.cmake#L273) but was not supported at the root level.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Silvio Traversaro <silvio.traversaro@iit.it>
@traversaro traversaro requested a review from caguero as a code owner October 4, 2023 11:35
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Oct 4, 2023
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #393 (019129f) into gz-msgs10 (0472ba0) will not change coverage.
The diff coverage is n/a.

❗ Current head 019129f differs from pull request most recent head e2cc2ab. Consider uploading reports for the commit e2cc2ab to get more accurate results

@@            Coverage Diff             @@
##           gz-msgs10     #393   +/-   ##
==========================================
  Coverage      97.26%   97.26%           
==========================================
  Files             27       27           
  Lines           1170     1170           
==========================================
  Hits            1138     1138           
  Misses            32       32           

@mjcarroll mjcarroll merged commit 0f69062 into gazebosim:gz-msgs10 Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants