Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate ign to gz #105

Merged
merged 2 commits into from
Jul 16, 2022
Merged

Migrate ign to gz #105

merged 2 commits into from
Jul 16, 2022

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Jul 15, 2022

🎉 New feature

Summary

Adapt code to the new gz naming instead of ignition

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested review from azeey and scpeters July 15, 2022 11:19
@ahcorde ahcorde self-assigned this Jul 15, 2022
Signed-off-by: ahcorde <ahcorde@gmail.com>
@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #105 (bd3b19a) into main (fd5dec3) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #105   +/-   ##
=======================================
  Coverage   95.20%   95.20%           
=======================================
  Files          24       24           
  Lines        1168     1168           
=======================================
  Hits         1112     1112           
  Misses         56       56           
Impacted Files Coverage Δ
.../sdformat_mjcf/sdformat_to_mjcf/converters/link.py 100.00% <ø> (ø)
...ormat_mjcf/mjcf_to_sdformat/converters/geometry.py 96.84% <100.00%> (ø)
...sdformat_mjcf/mjcf_to_sdformat/converters/joint.py 89.23% <100.00%> (ø)
...sdformat_mjcf/mjcf_to_sdformat/converters/light.py 100.00% <100.00%> (ø)
.../sdformat_mjcf/mjcf_to_sdformat/converters/link.py 100.00% <100.00%> (ø)
...dformat_mjcf/mjcf_to_sdformat/converters/sensor.py 100.00% <100.00%> (ø)
...sdformat_mjcf/mjcf_to_sdformat/converters/world.py 97.56% <100.00%> (ø)
...sdformat_mjcf/sdformat_to_mjcf/converters/joint.py 97.56% <100.00%> (ø)
...ormat_mjcf/sdformat_to_mjcf/converters/material.py 100.00% <100.00%> (ø)
sdformat_mjcf/src/sdformat_mjcf/utils/sdf_utils.py 90.09% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd5dec3...bd3b19a. Read the comment docs.

@scpeters scpeters merged commit 01d2105 into main Jul 16, 2022
@scpeters scpeters deleted the ahcorde/ign_2_gz branch July 16, 2022 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants