Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default joint limits #106

Merged
merged 1 commit into from
Aug 19, 2022
Merged

Fix default joint limits #106

merged 1 commit into from
Aug 19, 2022

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Follow up to gazebosim/sdformat#1112

Summary

Use updated default joint limits

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Follow up to gazebosim/sdformat#1112

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahcorde
Copy link
Collaborator

ahcorde commented Aug 18, 2022

One test it's failing https://github.com/gazebosim/gz-mujoco/runs/7887897191?check_suite_focus=true

Do we need a release?

@ahcorde ahcorde added the needs upstream release Blocked by a release if an upstream library label Aug 18, 2022
@codecov
Copy link

codecov bot commented Aug 19, 2022

Codecov Report

Merging #106 (9d8fafa) into main (01d2105) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #106   +/-   ##
=======================================
  Coverage   95.20%   95.20%           
=======================================
  Files          24       24           
  Lines        1168     1168           
=======================================
  Hits         1112     1112           
  Misses         56       56           
Impacted Files Coverage Δ
...sdformat_mjcf/sdformat_to_mjcf/converters/joint.py 97.56% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@azeey azeey dismissed ahcorde’s stale review August 19, 2022 22:08

Tests are passing now

@azeey azeey merged commit 8ec2db7 into main Aug 19, 2022
@azeey azeey deleted the scpeters/better_joint_limits branch August 19, 2022 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs upstream release Blocked by a release if an upstream library
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants