Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency on dm-control #112

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Add dependency on dm-control #112

merged 1 commit into from
Aug 23, 2022

Conversation

azeey
Copy link
Collaborator

@azeey azeey commented Aug 23, 2022

🦟 Bug fix

Summary

This allows us to do pip install sdformat-mjcf and have dm-control automatically installed.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey requested a review from ahcorde August 23, 2022 20:27
@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #112 (a9de563) into main (cbafb27) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #112   +/-   ##
=======================================
  Coverage   95.30%   95.30%           
=======================================
  Files          24       24           
  Lines        1171     1171           
=======================================
  Hits         1116     1116           
  Misses         55       55           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@azeey azeey merged commit fbb82a9 into gazebosim:main Aug 23, 2022
@azeey azeey deleted the dep_dm_control branch August 23, 2022 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants