Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update imports #114

Merged
merged 2 commits into from
Sep 21, 2022
Merged

Update imports #114

merged 2 commits into from
Sep 21, 2022

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Sep 16, 2022

Signed-off-by: ahcorde ahcorde@gmail.com

🦟 Bug fix

Summary

Imports have change from gz.math to gz-math{version} and sdformat to sdformat{version}

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from azeey September 16, 2022 11:38
@ahcorde ahcorde self-assigned this Sep 16, 2022
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #114 (fcf713e) into main (a00380f) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #114   +/-   ##
=======================================
  Coverage   95.30%   95.30%           
=======================================
  Files          24       24           
  Lines        1171     1171           
=======================================
  Hits         1116     1116           
  Misses         55       55           
Impacted Files Coverage Δ
...ormat_mjcf/mjcf_to_sdformat/converters/geometry.py 96.84% <100.00%> (ø)
...sdformat_mjcf/mjcf_to_sdformat/converters/joint.py 89.23% <100.00%> (ø)
...sdformat_mjcf/mjcf_to_sdformat/converters/light.py 100.00% <100.00%> (ø)
.../sdformat_mjcf/mjcf_to_sdformat/converters/link.py 100.00% <100.00%> (ø)
...ormat_mjcf/mjcf_to_sdformat/converters/material.py 95.65% <100.00%> (ø)
...dformat_mjcf/mjcf_to_sdformat/converters/sensor.py 100.00% <100.00%> (ø)
...sdformat_mjcf/mjcf_to_sdformat/converters/world.py 97.56% <100.00%> (ø)
...sdformat_mjcf/mjcf_to_sdformat/mjcf_to_sdformat.py 100.00% <100.00%> (ø)
...sdformat_mjcf/sdformat_to_mjcf/converters/joint.py 97.56% <100.00%> (ø)
...sdformat_mjcf/sdformat_to_mjcf/converters/light.py 100.00% <100.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@azeey azeey merged commit d6c2212 into main Sep 21, 2022
@azeey azeey deleted the ahcorde/update/pythonlibs branch September 21, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants