Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a crash due to an invalid pointer #486

Merged
merged 2 commits into from
Mar 18, 2023
Merged

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Mar 14, 2023

🦟 Bug fix

Summary

A crash could occur if _parent is null and the joint type is FreeJoint.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Nate Koenig <natekoenig@gmail.com>
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Mar 14, 2023
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #486 (82b43a0) into ign-physics2 (0ac0be1) will increase coverage by 0.02%.
The diff coverage is 96.15%.

❗ Current head 82b43a0 differs from pull request most recent head d7d0ea7. Consider uploading reports for the commit d7d0ea7 to get more accurate results

@@               Coverage Diff                @@
##           ign-physics2     #486      +/-   ##
================================================
+ Coverage         83.15%   83.18%   +0.02%     
================================================
  Files               108      108              
  Lines              4210     4210              
================================================
+ Hits               3501     3502       +1     
+ Misses              709      708       -1     
Impacted Files Coverage Δ
dartsim/src/Base.hh 99.01% <ø> (ø)
dartsim/src/KinematicsFeatures.cc 72.00% <ø> (ø)
dartsim/src/ShapeFeatures.cc 43.04% <ø> (ø)
dartsim/src/SimulationFeatures.cc 82.90% <ø> (ø)
dartsim/src/SimulationFeatures.hh 100.00% <ø> (ø)
dartsim/src/plugin.cc 100.00% <ø> (ø)
include/gz/physics/detail/BoxShape.hh 100.00% <ø> (ø)
include/gz/physics/detail/CanReadData.hh 100.00% <ø> (ø)
include/gz/physics/detail/CanWriteData.hh 100.00% <ø> (ø)
include/gz/physics/detail/Cloneable.hh 100.00% <ø> (ø)
... and 92 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@azeey azeey removed their request for review March 14, 2023 20:31
@scpeters scpeters merged commit c4629f6 into ign-physics2 Mar 18, 2023
@scpeters scpeters deleted the nkoenig/avoid_crash branch March 18, 2023 00:45
traversaro pushed a commit to traversaro/ign-physics that referenced this pull request Jun 8, 2023
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants