Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building with gz-cmake3 or gz-cmake4 #128

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Oct 12, 2023

🎉 New feature

Part of gazebo-tooling/release-tools#1027

Summary

We are bumping gz-cmake for Ionic to version 4, which would normally mean we would bump gz-tools, but this would prevent us from being able to install Ionic side-by-side with Harmonic and any older Gazebo collection. To remedy that, since we are not relying on any shared libraries from gz-cmake, we can support building with either gz-cmake3 or gz-cmake4.

Test it

  • test with gz-cmake3 by installing it and trying to build this PR
  • test with gz-cmake4 by building the main branch of gz-cmake and then building this PR.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey requested a review from iche033 October 12, 2023 21:50
@azeey azeey requested a review from caguero as a code owner October 12, 2023 21:50
@github-actions github-actions bot added 🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic labels Oct 12, 2023
Copy link
Member

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll want to revert the gazebodistro changes back to using gz-tools2 branch for ionic files

@azeey azeey merged commit df21e26 into gz-tools2 Oct 13, 2023
12 checks passed
@azeey azeey deleted the azeey/support_gz_cmake4 branch October 13, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants