Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed usd2sdf when import from model:// #10

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Aug 15, 2022

Signed-off-by: ahcorde ahcorde@gmail.com

🦟 Bug fix

Summary

Moved from here gazebosim/sdformat#1023

Added the model:// path to the set of folder where sdf should look for models and textures

FYI @rbonghi

SDF_PATH="models" IGN_FILE_PATH="models" sdf2usd worlds/office.sdf office.usda

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Aug 15, 2022
@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

Attention: Patch coverage is 5.88235% with 16 lines in your changes missing coverage. Please review.

Project coverage is 64.84%. Comparing base (157a5a1) to head (10d1792).
Report is 6 commits behind head on main.

Files Patch % Lines
src/sdf_parser/Geometry.cc 5.88% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
- Coverage   65.17%   64.84%   -0.34%     
==========================================
  Files          29       29              
  Lines        2958     2975      +17     
==========================================
+ Hits         1928     1929       +1     
- Misses       1030     1046      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

2 participants