-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: linter tests #251
fix: linter tests #251
Conversation
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
@chapulina I appreciate it if you do bloom-release to |
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I pushed 94da01d with 2 changes:
- Restore testing repo for CI
- Instead of suppressing the ament warnings, fix the include headers. This is finally our chance to group the Gazebo and ROS C++ headers together 😄
I noticed there's a test failure both locally for me and on CI. I'm not sure if it's something we're doing wrong or some regression upstream. I'll merge with that failure for now, since this PR is about linters.
[4.654s] 1: [test_ros_subscriber-3] cannot publish data, at ./src/rmw_publish.cpp:62 during '__function__'
[4.655s] 1: [test_ros_subscriber-3] [ERROR] [1653006329.567666397] [ros_subscriber.rclcpp]: Error in destruction of rcl subscription handle: Failed to delete datareader, at ./src/subscription.cpp:52, at ./src/rcl/subscription.c:183
[4.655s] 1: [test_ros_subscriber-3] cannot publish data, at ./src/rmw_publish.cpp:62 during '__function__'
[4.655s] 1: [test_ros_subscriber-3] Fail in delete datareader, at ./src/rmw_service.cpp:103 during '__function__'
🦟 Bug fix
Fixes #
Summary
fix some linter tests
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.