client: add new metric instrumentation for reads & appends #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Give particular focus to fragment reads, surfacing the number of client-initiated fragment reads and related size metrics.
willdonnelly
approved these changes
Feb 14, 2022
| }, []string{"journal", "codec"}) | ||
| readFragmentBytes = promauto.NewCounterVec(prometheus.CounterOpts{ | ||
| Name: "gazette_read_fragment_bytes_total", | ||
| Help: "Total number of journal fragment bytes read, excluding discarded bytes.", |
There was a problem hiding this comment.
It would probably be good for the description here to explicitly state that this is uncompressed, because I could see somebody reading "fragment bytes" as meaning "bytes of compressed fragment data from cloud storage".
| }, []string{"journal", "codec"}) | ||
| discardFragmentBytes = promauto.NewCounterVec(prometheus.CounterOpts{ | ||
| Name: "gazette_discard_fragment_bytes_total", | ||
| Help: "Total number of journal fragment bytes discarded while seeking to desired offset.", |
jgraettinger
commented
Feb 14, 2022
There was a problem hiding this comment.
Thanks
Reviewable status: 0 of 5 files reviewed, 2 unresolved discussions
broker/client/doc.go, line 91 at r1 (raw file):
Previously, willdonnelly (Will Donnelly) wrote…
It would probably be good for the description here to explicitly state that this is uncompressed, because I could see somebody reading "fragment bytes" as meaning "bytes of compressed fragment data from cloud storage".
Done.
broker/client/doc.go, line 95 at r1 (raw file):
Previously, willdonnelly (Will Donnelly) wrote…
Also here.
Done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give particular focus to fragment reads, surfacing the number of
client-initiated fragment reads and related size metrics.
This change is