Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix addr alignment in witness #366

Merged
merged 1 commit into from
Feb 15, 2024
Merged

fix addr alignment in witness #366

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/state/access_witness.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ type branchAccessKey struct {

func newBranchAccessKey(addr []byte, treeIndex uint256.Int) branchAccessKey {
var sk branchAccessKey
copy(sk.addr[:], addr)
copy(sk.addr[20-len(addr):], addr)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If len(addr)<20 this was doing the copy incorrectly.

Another option for this particular bug case is not doing this code line change, and do:
image

But I think this proposed change is more general, and if we have a similar situation in other place the current fix would cover it.

Open to opinions though.

sk.treeIndex = treeIndex
return sk
}
Expand Down
Loading