Add EXTCODEHASH witnes information to resolve Empty() #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
jsign
commented
Apr 15, 2024
Comment on lines
+68
to
+70
| codehashgas := evm.Accesses.TouchVersion(address[:], false) | ||
| codehashgas += evm.Accesses.TouchBalance(address[:], false) | ||
| codehashgas += evm.Accesses.TouchNonce(address[:], false) |
There was a problem hiding this comment.
New fields to resolve Empty(...) in witness.
gballet
requested changes
Apr 26, 2024
There was a problem hiding this comment.
The spec is quite clear that only the code hash should be touched. Which makes sense. The better approach would be to only check the code hash instead of the whole account. If that can't be done, then we would need a spec change. But we can't merge this as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EXTCODEHASHinstruction execution does an.Empty(address)check to early return a zero. ThisEmpty(...)implies adding to the witness the nonce and balance.Note: I added the version too to be coherent with the current status quo