Message call witness gas charging #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwasinger
force-pushed
the
message-call-witness-gas-charging
branch
2 times, most recently
from
a534515 to
64ad793
Compare
jwasinger
force-pushed
the
message-call-witness-gas-charging
branch
from
dd7f84a to
40ed0c0
Compare
jwasinger
force-pushed
the
message-call-witness-gas-charging
branch
from
fa38b92 to
d1fdcdd
Compare
jwasinger
force-pushed
the
message-call-witness-gas-charging
branch
from
d1fdcdd to
5769e36
Compare
gballet
reviewed
Jan 5, 2022
gballet
requested changes
Jan 13, 2022
jwasinger
force-pushed
the
message-call-witness-gas-charging
branch
from
17d1d09 to
9825e44
Compare
jwasinger
force-pushed
the
message-call-witness-gas-charging
branch
from
9825e44 to
15d84a9
Compare
|
Merged in #60, closing |
gballet
added a commit
that referenced
this pull request
Jun 14, 2022
Co-authored-by: ubuntu <ubuntu@geth-verkle1.ethdevops.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on top of #42
Adds part of the logic for witness gas charging from https://notes.ethereum.org/-fJSOrnYQl-mqoWKpaTIsQ . Note that this treats all events as access events unlike the spec. The purpose of this PR is to put in place the logic necessary to charge witness gas costs for message calling (
CALL,CALLCODE,DELEGATECALL,STATICCALL,SELFDESTRUCT,CREATE,CREATE2).Once this PR is done and approved, I will rebase #37 and change the individual
Touch*calls to eitherTouchOnReadAndChargeGasorTouchOnWriteAndChargeGas.