fix: add history contract to TestProcessorVerkle #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsign
reviewed
Sep 27, 2024
| @@ -669,6 +681,10 @@ func TestProcessVerkleInvalidContractCreation(t *testing.T) { | |||
| Balance: big.NewInt(1000000000000000000), // 1 ether | |||
| Nonce: 1, | |||
| }, | |||
| params.HistoryStorageAddress: GenesisAccount{ | |||
There was a problem hiding this comment.
Ideally we should add it with the right code, correct?
Maybe irrelevant for these tests, but we can pull the code from the GenesisAlloc in execution-spec-tests if useful.
There was a problem hiding this comment.
iirc, we decided to use the code for mainnet, but in the spec it's fine as long as the account exists (which it will with nonce 1).
There was a problem hiding this comment.
and I'd prefer waiting for the contract to have been reviewed before adding it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 7709 it's specified that any testnet that didn't somehow deploy a history storage contract is buggy. That was the case here.