Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify safe.directory for git describe to get the version #1640

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

Rangi42
Copy link
Contributor

@Rangi42 Rangi42 commented Jan 29, 2025

The Cygwin and FreeBSD CI tests cannot get the RGBDS version string because of directory permissions, and it's possible for end users to have the same issue (e.g. if they're using WSL on Windows and mix up which git to use).

See https://github.blog/open-source/git/highlights-from-git-2-36/#stricter-repository-ownership-checks for why this is necessary.

@Rangi42 Rangi42 added the tests This affects the test suite label Jan 29, 2025
@Rangi42 Rangi42 added this to the 0.9.1 milestone Jan 29, 2025
@Rangi42
Copy link
Contributor Author

Rangi42 commented Jan 29, 2025

Both FreeBSD and Cygwin still can't run the version test because git describe complains "fatal: No names found, cannot describe anything." Note that FreeBSD at least does copy the .git directory into its VM, so I'd expect the tags to be available for describing the RGBDS version. (To do: check the content of .git/info/refs?)

@Rangi42 Rangi42 marked this pull request as draft January 29, 2025 18:24
@Rangi42 Rangi42 marked this pull request as ready for review January 30, 2025 00:56
@Rangi42 Rangi42 merged commit 03452c6 into gbdev:master Jan 30, 2025
26 checks passed
@Rangi42 Rangi42 deleted the git-safe-directory branch January 30, 2025 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests This affects the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant