Fix error() formatting in rgbasm #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rangi42
approved these changes
Mar 1, 2021
ISSOtm
requested changes
Mar 2, 2021
ISSOtm
requested changes
Mar 2, 2021
daid
force-pushed
the
FixExceptionalMessagesPrintfWarnings
branch
from
b4de6cf
to
516f756
Compare
…led a few times with wrong parameters. Fix the call to error() from perser.y Fix size parameter of %.*s format being an int... bonkers standard. Report the number of arguments required and provided on a strfmt mismatch Make the STRFMT test match the new message Add an assert to check for a very unlikely case
ISSOtm
approved these changes
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The asm error() function did not have a format attribute, and was called a few times with wrong parameters. Hasn't caused real issues as those errors are hard to impossible to trigger.