Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throws Errno::EEXIST: File exists @ dir_s_mkdir when tmp exists #3

Closed
bhavinkamani opened this issue Apr 26, 2014 · 5 comments
Closed

Comments

@bhavinkamani
Copy link

Call to Oxcelix::Workbook.new blows up with Errno::EEXIST: File exists @ dir_s_mkdir when tmp exists under the current directory. It happens due to FileUtils.mkdir(@destination) at workbook.rb:52. I would have sent you a pull request but could not make the specs run on my machine.

@gbiczo
Copy link
Owner

gbiczo commented Apr 28, 2014

Absolutely true, thank you for pointing that out!
Will try to fix the issue during the week.

@bhavinkamani
Copy link
Author

Thank you. BTW changing mkdir call to mkdir_p fixes the issue.

@gbiczo
Copy link
Owner

gbiczo commented May 4, 2014

Should work now... In the long run I think the Dir.mktmpdir will do the best job.
A question: what do you mean by "could not make the specs run on my machine"? And how is that preventing the pull request? I'm asking, because I'm relatively new to specs and to github as well :)

@bhavinkamani
Copy link
Author

Thanks a ton..

For any change in the dependent gem, typical community convention is to
ensure that all specs are green before submitting pull request. Since this
was a small change and I could not make specs run in my machine, I did not
bother to troubleshoot. Hence the request. You may want to add Gemfile.
That will make it easy for bundler to install dependencies. This will
people can setup their environment, run specs and send their contributions.

On Sun, May 4, 2014 at 9:17 PM, Giovanni Biczo notifications@git.luolix.topwrote:

Should work now... In the long run I think the Dir.mktmpdir will do the
best job.
A question: what do you mean by "could not make the specs run on my
machine"? And how is that preventing the pull request? I'm asking, because
I'm relatively new to specs and to github as well :)


Reply to this email directly or view it on GitHubhttps://github.com//issues/3#issuecomment-42136059
.

@gbiczo
Copy link
Owner

gbiczo commented May 10, 2014

Got it, thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants