Make tests in test_play_for.cpp more deterministic and run faster #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Redesigned tests to be more deterministic and running faster * Fixed bug in `play_for()` flow when replaying in loop or multiple times from the same player instance. Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
gbiggs
approved these changes
Mar 28, 2022
gbiggs
pushed a commit
that referenced
this pull request
Mar 30, 2022
* Redesigned tests to be more deterministic and running faster * Fixed bug in `play_for()` flow when replaying in loop or multiple times from the same player instance. Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
gbiggs
pushed a commit
that referenced
this pull request
May 11, 2022
* Redesigned tests to be more deterministic and running faster * Fixed bug in `play_for()` flow when replaying in loop or multiple times from the same player instance. Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
gbiggs
pushed a commit
that referenced
this pull request
Jun 1, 2022
* Redesigned tests to be more deterministic and running faster * Fixed bug in `play_for()` flow when replaying in loop or multiple times from the same player instance. Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
gbiggs
added a commit
that referenced
this pull request
Jun 6, 2022
* Add play-for functionality Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Add play-for to the CLI Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Solves most of the comments from https://github.com/ros2/rosbag2/pull/960/files (#14) * Add play-for functionality Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Add play-for to the CLI Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Adds playback_duration to PlayOptions. * Changes from PlayFor to Play srv message and changes start_offset and playback_duration. * Restores play_for tests. * Removes extra SubscriptionManager methods. * Solves comment about extra sent message. * Reorders code and comment. * Removes the SKIP_TEST flag. Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Second round of comments from ros2#960 upstream (#15) * Removes duration parameter. A leftover after switching to playback_duration. * Fixes comment. * Solves format in rosbag2_py -> _transport.cpp * Applies style suggestions. * Changes play() to return a boolean indicating whether the request could be fulfilled. * Removes extra unnecessary code. Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Updates test execution time for ros2#960 (#16) * Adresses reviewer's comments. * Improve test time by adding an optional argument to SubscriptionManager::spin_subscriptions() - Reduces test_play_for execution time from 50s to 6s approximately. Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Redesign tests in test_play_for.cpp (#17) * Redesigned tests to be more deterministic and running faster * Fixed bug in `play_for()` flow when replaying in loop or multiple times from the same player instance. Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Remove unnecessary source file from test binary Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Correct errors introduced by rebase Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Correct play_next behaviour Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> Co-authored-by: Agustin Alba Chicar <ag.albachicar@ekumenlabs.com> Co-authored-by: Michael Orlov <morlovmr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@agalbachicar It was to tedious making a lot of comments and propose changes on code review.
I prepared all proposed changes on separate branch.
I had a concern that after last changes tests still rely on the assumption that subscription waiting for
Nmessages however in tests valid expectation that it will be published less thenNmessages or nothing. And waiting time reduced to the 1 second.Such assumption tend to make tests false negative or flaky due to the possible delays on CI.
Please consider to merge my changes on your branch as result of the code review.
What has been done:
play_for()flow when replaying in loop or multipletimes from the same player instance.
Signed-off-by: Michael Orlov michael.orlov@apex.ai