fix warnings/release notes for Weekdays setting

addendum to PR connamara#864 on issue connamara#844
gbirchmeier · May 29, 2024 · c9d51d9 · c9d51d9
1 parent c609125
commit c9d51d9
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/QuickFIXn/SessionSchedule.cs b/QuickFIXn/SessionSchedule.cs
@@ -250,6 +250,9 @@ public SessionSchedule(SettingsDictionary settings)
 
                 _weekdays = settings.GetDays(SessionSettings.WEEKDAYS);
             }
+            else {
+                _weekdays = new();
+            }
 
             if (!settings.Has(SessionSettings.START_DAY) && settings.Has(SessionSettings.END_DAY))
                 throw new QuickFix.ConfigError("EndDay used without StartDay");

diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
@@ -60,7 +60,6 @@ What's New
      * Also refactor the heck out of DateTimeConverter & tests: many functions renamed/deprecated
 * #847 - remove setting MillisecondsInTimeStamp (gbirchmeier)
      * Use TimestampPrecision instead (same as QF/j)
-* #844 - implement "Weekdays" setting (MichalUssuri/gbirchmeier)
 
 **Non-breaking changes**
 * #400 - added DDTool, a C#-based codegen, and deleted Ruby-based generator (gbirchmeier)
@@ -83,6 +82,7 @@ What's New
       Programming Model (APM), in order to catch unobserved SocketExceptions (nmandzyk)
     * Cleanup/nullable-ize SocketInitiatorThread (gbirchmeier)
 * #839 - change ScreenLog to output FIX messages with "|" instead of non-visible SOH (gbirchmeier)
+* #844 - implement "Weekdays" setting (MichalUssuri/gbirchmeier)
 
 ### v1.11.2:
 * same as v1.11.1, but I fixed the readme in the pushed nuget packages

diff --git a/UnitTests/SettingsDictionaryTests.cs b/UnitTests/SettingsDictionaryTests.cs
@@ -117,7 +117,7 @@ public void TestGetDay()
 
         d.SetString("DAY_X", "invalid");
         var ex = Assert.Throws(typeof(ArgumentException), delegate { d.GetDay("DAY_X"); });
-        StringAssert.Contains("Cannot recognize this day: 'invalid'", ex.Message);
+        StringAssert.Contains("Cannot recognize this day: 'invalid'", ex!.Message);
     }
 
     [Test]
@@ -130,7 +130,7 @@ public void TestSetDay() {
         Assert.That(d.GetString("DAY4"), Is.EqualTo("Thursday"));
 
         var ex = Assert.Throws(typeof(ArgumentException), delegate { d.SetDay("X", (DayOfWeek)9); });
-        StringAssert.Contains("Not a valid DayOfWeek value", ex.Message);
+        StringAssert.Contains("Not a valid DayOfWeek value", ex!.Message);
     }
 
     [Test]