Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calculation of pivot wavelength in FilterDefinition class #40

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

hbahk
Copy link
Contributor

@hbahk hbahk commented Apr 16, 2024

Hello, I noticed an error in the calculation of the pivot wavelength. The first and second arguments for np.trapz need to be swapped to fix this.

@gbrammer
Copy link
Owner

Right, thanks @hbahk !

@gbrammer gbrammer merged commit 42cdf07 into gbrammer:master Jun 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants