Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

registryForScheme: Use a cache for initialized registries #42

Closed
2 tasks done
Tracked by #670
stefandesu opened this issue Feb 23, 2022 · 0 comments
Closed
2 tasks done
Tracked by #670

registryForScheme: Use a cache for initialized registries #42

stefandesu opened this issue Feb 23, 2022 · 0 comments
Milestone

Comments

@stefandesu
Copy link
Member

stefandesu commented Feb 23, 2022

If two schemes use the same API, they should also be assigned the same registry object so that the initialization of that registry (which involved making a request to its /status endpoint) is not performed multiple times. See also the implementation in BARTOC (which should be replaced by this): https://github.com/gbv/bartoc.org/blob/main/vue/utils.js

  • Implement the caching
  • Make sure schemes that belong to the same registry are all in the registry's _api.schemes field (this was a recent bug in BARTOC)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant