Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "prev" button #501

Closed
nichtich opened this issue Oct 30, 2019 · 7 comments
Closed

Add "prev" button #501

nichtich opened this issue Oct 30, 2019 · 7 comments
Labels
feature Additional functionality user experience Usage should be fun and easy
Milestone

Comments

@nichtich
Copy link
Member

In addition to the "next concept" button there should be a reverse "previous concept" button. Keyboard shortcuts could be Alt+J and Alt+K. If this takes more time to implement, move to next milestone!

@nichtich nichtich added user experience Usage should be fun and easy feature Additional functionality labels Oct 30, 2019
@nichtich nichtich added this to the 1.2.0 milestone Oct 30, 2019
@stefandesu
Copy link
Member

I quickly tried to implement this because the algorithm to determine the previous concept is very easy, BUT there is one issue, maybe you have an idea how to go around this: If the previous child (relative to the current concept) has children, the previous button should point to its last child. But generally, its children aren't even loaded yet, we just know that there are children, but not how many or which ones. So in this case, the previous concept can't be determined.

We could add a piece of code that loads the previous child's children whenever a concept is selected. That would add a tiny bit of overhead, but shouldn't be too bad. What do you think?

@nichtich
Copy link
Member Author

nichtich commented Nov 1, 2019

Would triggering the loading only when prev-button is activated work?

@stefandesu
Copy link
Member

stefandesu commented Nov 1, 2019

Would triggering the loading only when prev-button is activated work?

Do you mean when the button is clicked? You can activate or deactivate the button.

Edit: That would be possible, but add a little bit of complexity to the issue.

@nichtich nichtich modified the milestones: 1.2.0, 1.3.0 Nov 1, 2019
@nichtich
Copy link
Member Author

nichtich commented Nov 1, 2019

Better no additional complexity nor speed penalty for such an issue. Maybe complexity can be reduced by general refactoring, e.g. #74.

@stefandesu
Copy link
Member

Either way, there will be added complexity to this issue because refactoring does not change the underlying problem that the children of previous concepts might not be loaded yet.

@stefandesu
Copy link
Member

So with #505, I could easily add the prevButton for lists without hierarchy, like favorite concepts or custom lists. The problem with unknown children still exists for lists with a hierarchy. Should we add the prevButton for flat lists?

@nichtich
Copy link
Member Author

nichtich commented Nov 6, 2019

Yes, support for flat lists should be enough to start with and to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Additional functionality user experience Usage should be fun and easy
Projects
None yet
Development

No branches or pull requests

2 participants