-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offer deployment via Docker #553
Comments
I have added a Docker branch where I added necessary files to create a Docker container for Cocoda. Further steps needed:
This is only for Cocoda itself. Of course we would have to repeat the same things for jskos-server and login-server, and then somewhere offer the example docker-compose file on how to integrate them all. |
Some certain changes to the file structure (especially regarding configuration files) might make sense, but that would cause old versions to break, so I'll have to see whether it makes sense. It might be better to solve it inside the Docker image. |
The issue I mentioned in the previous comment is that the configuration file ( Also it would be good to move all docker-related files into a separate directory. During testing a while back I had some issues with creating and publishing the image from GitHub Actions, but that should be solvable. |
I created an organization and repository on Docker Hub: https://hub.docker.com/repository/docker/coliconc/cocoda I will now make deployment work in the |
Deployment works. Branches are now deployed via their branch names (currently only *To be honest, I'm not 100% confident that this will work because we changed the default branch. I might do some testing on my test repo before we merge into dev. Now, it's mostly a matter of documentation. I would suggest to add Docker deployment information to |
It's okay. If we rename master, we just need to make a small change inside I'll improve documentation tomorrow, then I'll merge and close this issue. |
The |
Docker deployment worked perfectly with the just-released version 1.4.0: https://hub.docker.com/repository/docker/coliconc/cocoda |
I had this suggestion before, but apparently never created an issue for it. I think it would make a lot of sense to offer deployment via Docker. I would suggest offering separate Docker container for Cocoda, jskos-server, and login-server, and then offer an example docker-compose file that includes all of these (including a MongoDB for jskos-server and login-server).
It shouldn't be too difficult to offer this. It would probably make sense to create a separate repository though (maybe one repository which includes all Docker containers and the docker-compose example).
(I thought of this due to #550 because setting up your own instance will become even easier when Docker is available.)
The text was updated successfully, but these errors were encountered: