Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve workflow for changing the identity used for one's own mapping #560

Closed
stefandesu opened this issue May 26, 2020 · 1 comment
Closed
Milestone

Comments

@stefandesu
Copy link
Member

This issue is hard to describe. Considering the following example:

  • You save a mapping using identity A.
  • You switch your identity to B and decide to use identity B for all mappings from now on.
  • On the created mapping, it will show the yellow exclamation mark that the identity is different from the currently selected one.
  • You edit that mapping, but at that moment, it will be shown as unchanged, therefore you won't be able to save it with the new identity B.
  • To be able to save it, you have to switch your identity back and forth while the mapping is being edited.

Instead, it should be a two-click workflow: You see the exclamation mark, you click edit, you click save.

@stefandesu stefandesu added this to the 1.3.2 milestone May 26, 2020
@stefandesu
Copy link
Member Author

This was already intended, it just wasn't working when no scheme on either side was selected because MappingEditor got unmounted and remounted which caused the creator to not update properly. Fixed by updating the creator in MappingEditor's mounted call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant