-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for new way to specify creator identity in jskos-server #591
Comments
I am suggesting a new behavior for the "Name" field in the Cocoda settings (assuming the user is logged in). Current behavior:
New behavior:
For compatibility purposes and local mappings and so on, I would suggest that creator/contributor in mappings is still adjusted like it is at the moment (except with the new logic above). But in addition to that, we will add @nichtich Is this okay for you? |
This commit allows the user to choose any name regardless of identity URI.
I implemented like described above. Since gbv/jskos-server#122 is not yet merged into dev, it can't be tested right now, but it works well locally for me. Also it means that the name can now freely be chosen in Cocoda dev even with older jskos-server instances, I think. |
I will implement some further changes how |
There's still a bug left where the creator name might (?) change after reloading the page. |
gbv/jskos-server#122 is now merged into dev, so this new behavior can be tested on https://coli-conc.gbv.de/cocoda/dev/. Ideally, please test with both the dev and master instances of jskos-server because it should be compatible with both. If everything works, I would like to release 1.4.3 tomorrow. |
I did some short tests and it seems to work perfectly. @nichtich Can you try it out as well? |
See gbv/jskos-server#122.
The text was updated successfully, but these errors were encountered: