Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new way to specify creator identity in jskos-server #591

Closed
stefandesu opened this issue Nov 12, 2020 · 6 comments
Closed
Milestone

Comments

@stefandesu
Copy link
Member

See gbv/jskos-server#122.

@stefandesu stefandesu added this to the 1.4.3 milestone Nov 12, 2020
@stefandesu
Copy link
Member Author

I am suggesting a new behavior for the "Name" field in the Cocoda settings (assuming the user is logged in).

Current behavior:

  • For the Login Server URI, the name is editable and changes the name not only in Cocoda, but also in Login Server.
  • For additional URIs (ORCID, etc.), the name is not editable and fixed to the name provided for that particular identity.

New behavior:

  • The name is always editable and never submitted back to Login Server.
  • Whenever the user changes the identity URI that is used, we prefill the name with that identity's name (which can then be adjusted by the user).
  • As long as there's an identity (which is always as long as the user is logged in), we allow the user to set an empty name so that only their identity URI is saved into a mapping.

For compatibility purposes and local mappings and so on, I would suggest that creator/contributor in mappings is still adjusted like it is at the moment (except with the new logic above). But in addition to that, we will add identity and identityName params to POST/PUT requests as implemented in gbv/jskos-server#122.

@nichtich Is this okay for you?

stefandesu added a commit that referenced this issue Nov 16, 2020
This commit allows the user to choose any name regardless of identity URI.
@stefandesu
Copy link
Member Author

I implemented like described above. Since gbv/jskos-server#122 is not yet merged into dev, it can't be tested right now, but it works well locally for me. Also it means that the name can now freely be chosen in Cocoda dev even with older jskos-server instances, I think.

@stefandesu
Copy link
Member Author

I will implement some further changes how creator and contributor are handled in Cocoda. Even though it's not relevant when using the updated jskos-server, it affects local mappings in particular.

@stefandesu
Copy link
Member Author

There's still a bug left where the creator name might (?) change after reloading the page.

@stefandesu
Copy link
Member Author

gbv/jskos-server#122 is now merged into dev, so this new behavior can be tested on https://coli-conc.gbv.de/cocoda/dev/. Ideally, please test with both the dev and master instances of jskos-server because it should be compatible with both. If everything works, I would like to release 1.4.3 tomorrow.

@stefandesu
Copy link
Member Author

I did some short tests and it seems to work perfectly. @nichtich Can you try it out as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant