-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MappingNavigator: remove visual clutter by opiniated settings #639
Comments
I disagree. Especially for beginners, I think it is extremely helpful to see that there is a data source which could provide mappings, but that simply doesn't have any results for the current search. Also, we would then need to differentiate between no results and an error loading the mappings. If we remove the setting, I'd rather have the default be to always show empty sections. (To be honest, I'm not super sure how it is currently handled if a section is empty but there was an error if "show empty sections" is turned off.)
I don't care much about this either way, so we can this. |
Replaces user preference with opinionated default.
Replaces user preference with opinionated default.
I thought this was something that we could easily implement for 1.5.0 and chose to go for:
I'm open for further discussion on the latter point, but here is my reasoning again:
If you look at the commit diffs for those changes, you'll also see that these two preferences involved basically no code. It was just one if condition. So we could also easily revert the changes if we can't decide how we want to deal with it at the moment. |
Opinionated settings to remove number of setting and visual clutter:
The only reason is to show empty sections is to allow selection of mapping database. This could also be done via dropdown at the selected registry name (both in mapping navigator and in mapping editor) or via the icons used to hide individual registries (maybe three states: show, hide, select).
The text was updated successfully, but these errors were encountered: