Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MappingNavigator: remove visual clutter by opiniated settings #639

Closed
nichtich opened this issue Nov 9, 2021 · 2 comments
Closed

MappingNavigator: remove visual clutter by opiniated settings #639

nichtich opened this issue Nov 9, 2021 · 2 comments
Labels
question Further discussion needed
Milestone

Comments

@nichtich
Copy link
Member

nichtich commented Nov 9, 2021

Opinionated settings to remove number of setting and visual clutter:

  • Currently selected mapping database alway at the top
  • Never show empty sections

The only reason is to show empty sections is to allow selection of mapping database. This could also be done via dropdown at the selected registry name (both in mapping navigator and in mapping editor) or via the icons used to hide individual registries (maybe three states: show, hide, select).

@nichtich nichtich added the question Further discussion needed label Nov 9, 2021
@stefandesu
Copy link
Member

stefandesu commented Nov 9, 2021

The only reason is to show empty sections is to allow selection of mapping database.

I disagree. Especially for beginners, I think it is extremely helpful to see that there is a data source which could provide mappings, but that simply doesn't have any results for the current search. Also, we would then need to differentiate between no results and an error loading the mappings. If we remove the setting, I'd rather have the default be to always show empty sections. (To be honest, I'm not super sure how it is currently handled if a section is empty but there was an error if "show empty sections" is turned off.)

Currently selected mapping database alway at the top

I don't care much about this either way, so we can this.

stefandesu added a commit that referenced this issue Nov 18, 2021
Replaces user preference with opinionated default.
stefandesu added a commit that referenced this issue Nov 18, 2021
Replaces user preference with opinionated default.
@stefandesu stefandesu added this to the 1.5.0 milestone Nov 18, 2021
@stefandesu
Copy link
Member

I thought this was something that we could easily implement for 1.5.0 and chose to go for:

  • Always show selected mapping database at the top (probably no discussion here).
  • Always show empty sections.

I'm open for further discussion on the latter point, but here is my reasoning again:

  • It's confusing to the user if a whole section disappears just because there are no results.
  • I also added a text "no results" to make it a bit clearer.
  • If there's an error with the registry, it will also be shown there.

If you look at the commit diffs for those changes, you'll also see that these two preferences involved basically no code. It was just one if condition. So we could also easily revert the changes if we can't decide how we want to deal with it at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further discussion needed
Projects
None yet
Development

No branches or pull requests

2 participants