Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use localized dates #655

Closed
nichtich opened this issue Dec 14, 2021 · 2 comments
Closed

Don't use localized dates #655

nichtich opened this issue Dec 14, 2021 · 2 comments
Labels
user experience Usage should be fun and easy

Comments

@nichtich
Copy link
Member

SchemeDetails card shows dates in German local format. Better use international format (YYYY-MM-DD) like in MappingTable.

grafik

@nichtich nichtich added the user experience Usage should be fun and easy label Dec 14, 2021
@stefandesu
Copy link
Member

I think localized date format is nice, but I'd be fine with changing it back to ISO format. You're right that it is not consistent with MappingBrowser, but I think the reasoning was that we have limited space in MappingBrowser and with ISO dates, we know know much space it will take (10 characters), while in SchemeDetail/ConceptDetail, we have much more space.

Should we just show the date like it is saved in JSKOS, e.g. 2021-12-13T07:46:24.235Z (if there's a time as well)? We could also make it a bit more readable and show it as 2021-12-13 07:46 (UTC).

@nichtich
Copy link
Member Author

For both vocabularies and schemes the exact timestamp is not relevant, better show date only and timestamp on hover. We could spare space by putting all dates in one line (if needed).

stefandesu added a commit that referenced this issue Dec 15, 2021
Introduces a new DateString component that is used instead.
@stefandesu stefandesu changed the title Don't use localized dates in SchemeDetail Don't use localized dates Dec 15, 2021
stefandesu added a commit that referenced this issue Dec 15, 2021
Forgot to add to last commit...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user experience Usage should be fun and easy
Projects
None yet
Development

No branches or pull requests

2 participants