Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to enable open world assumption in response data #158

Closed
Tracked by #670
nichtich opened this issue Feb 21, 2022 · 2 comments
Closed
Tracked by #670

Add option to enable open world assumption in response data #158

nichtich opened this issue Feb 21, 2022 · 2 comments

Comments

@nichtich
Copy link
Member

By default jskos-server uses closed world assumption, e.g. when a concept scheme has no concepts in the server instance, than its field concepts is returned with value [] indicating that no concept exist at all. The jskos-server instance of BARTOC should better be run under open world assumption.

Add a configuration option closedWorldAssumption with default true. If set to false, the method cleanJSON should remove all fields with empty array or empty object values. In example 12 of the JSKOS spec this would remove altLabel and notation.

@stefandesu
Copy link
Member

Sounds good. In short: All empty array and object values on the top level of any kind of entity will be removed before sending the data, if closedWorldAssumption is set to false, right? I was wondering if this could have any negative consequences, but as far as I can tell, there isn't any.

@stefandesu
Copy link
Member

stefandesu commented Feb 21, 2022

To-Dos:

  • Implementation
  • Check of implementation by @nichtich
  • Tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants