-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support bind
and bindTo
for Parser
monad
#31
Conversation
With using the methods from Parser monad, we don't need to depend on `fp-ts-contrib` anymore in this package.
Hey @CYBAI! Thank you very much for the PR! I also find myself frequently using I think a larger question that will need to be addressed with @gcanti is how to handle monadic libraries within the
As for your question about bumping the version of |
@gcanti - I am going to merge this PR as long as you have no objections. I am curious to hear your thoughts on my comment above though regarding how ecosystem libraries should handle the new pipeable |
I'm also curious about this and would be happy to migrate to a better solution in the future! |
LGTM, thanks @CYBAI
Like in this PR (for the moment), I might export |
Hi @gcanti, while upgrading a private repo to use
bind
andbindTo
introduced infp-ts@2.8.1
, I just noticed thatparser-ts
doesn't support these two methods.I wonder if it's good to also introduce them to
parser-ts
? Also, with introducingbind
andbindTo
toParser
monad, we're able to drop thefp-ts-contrib
dependency for theexamples/command.ts
in this repo.Also, if this PR is acceptable, should I update the
package.json
version in this PR? or it will be handled while publishing?Thank you! 🙇