-
Notifications
You must be signed in to change notification settings - Fork 13
Support React 15 #7
Comments
Hi @th0r, thanks for pointing out.
👍 I'll do that asap
Are you using |
I'm using |
Shit, what's going on there?! I restart node server and the order of attributes is right for the first 2 (???) queries:
But after the second one the order is changing (!!!):
WTF?!
Seems like a bug in React but I'm not sure... |
Just released in https://github.com/gcanti/tcomb-form-templates-bootstrap/releases/tag/v0.2.1 For what concerns server rendering I'll investigate further tomorrow (I'm not able to reproduce the issue right now). If in react 15 |
Working on this... maybe I could use |
Ok, just pushed on master (https://github.com/gcanti/tcomb-form) a possible fix. Could you please test it out in your use case? |
Here is the issue about changing attributes order (facebook/react#6451) so it's not even React bug. |
P.S. Node 6 doesn't have this bug. |
IDs look fine now. Thanks a lot! |
Thanks for testing out, a new release is on its way... |
When I migrated my universal app (browser + node) to React 15 I've noticed that I have 2 react versions in my webpack bundle.
Appeared that this package has
"react": "^0.14.0"
as its dep.I tried to change it to
^0.14.0 || ^15.0.0
and everything seemed fine except this "attempted to reuse markup" error:Looks like this package adds some id's to form fields on client but doesn't do it on server.
And also I think
react
dep should be underpeerDependencies
to throw an error in such situations. As I can see you've already done it fortcomb-form
.Thanks!
The text was updated successfully, but these errors were encountered: