Skip to content
This repository has been archived by the owner on Feb 16, 2021. It is now read-only.

Move React to peerDependecies and devDependencies #313

Closed
maksis opened this issue Apr 8, 2016 · 3 comments
Closed

Move React to peerDependecies and devDependencies #313

maksis opened this issue Apr 8, 2016 · 3 comments

Comments

@maksis
Copy link
Contributor

maksis commented Apr 8, 2016

Having React in dependencies causes confusing errors when people upgrade their projects to use React 15 due to multiple (conflicting) copies of React being loaded by the browser. Seems like this project used to have React in peerDepencencies but for some reason that was changed in 5834e92

Related discussion: JedWatson/react-select#88

@gcanti
Copy link
Owner

gcanti commented Apr 8, 2016

Hi @maksis,

would it be correct to move react to peerDependencies and to add v15?

"dependencies": {
-  "react": "^0.14.0",
  "tcomb-form-templates-bootstrap": "^0.2.0",
  "tcomb-validation": "^3.0.0"
},
+"peerDependencies": {
+  "react": "^0.14.0 || ^15.0.0"
+}

@maksis
Copy link
Contributor Author

maksis commented Apr 8, 2016

You'll probably want a dev dependency as well for running the tests

@gcanti
Copy link
Owner

gcanti commented Apr 8, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants