-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use peerDependencies for react reference #88
Comments
Yes please. I've been getting this for the past few hours and just narrowed it down to this. |
Thanks for the link to that SO answer; it explains why everyone's opening "make React a peerDependency" issues in my projects. As far as I can tell, However it's just as valid to specify |
Updating the dependency seems to have resolved the issue, let me know if it still causes any troubles. |
I believe this issue should be reopened. Declaring react as a dependency rather than a peerdep causes multiple copies of react to be loaded - I believe this is the cause of issue #112. react-router uses the strategy of declaring react as both a peerDependency and a devDependency for testing (remix-run/react-router#98). |
I've still got my reservations but have merged #88 so we'll see how it works out :) |
This means that it will use the version of react referenced by the application. Using different versions causes explode.
article about this here: http://stackoverflow.com/questions/27153166/typeerror-when-using-react-cannot-read-property-firstchild-of-undefined
The text was updated successfully, but these errors were encountered: