peerDependencies

[brigand]

I got some clarification on the peer dependencies issue.

It appears there's a semver caveat for 0.x.x versions where compatible means the same minor version, so ^0.10.0 is >=0.10.0 and <0.11.0, but I thought it meant >=0.10.0 and <1.0.0.

I apologize for the incorrect pull request.

"react": ">=0.10.0<1.0.0" would give the correct behavior, or simply "react": ">=0.10.0".

[bobeagan]

👍 to moving back to peerDeps with the modified version target

[mjackson]

is there a way to install peerDependencies using npm install ? I can't find it.

[mjackson]

We actually depend on React for a few things (i.e. we require('react/lib/...')), so it is an actual dependency. How does us moving to peerDeps help you?

[jlongster]

Right now, I have to fork react-nested-router and remove the react dependency to use it. I bundle everything with webpack and using this library bundles a whole other copy of React inside it, which is a non-starter.

Peer deps was initially meant to solve this, but a lot of people don't like them (in some cases it can force bad package installs or something, not sure). When I write plugins, I just don't specify a dependency at all, and just state the minimum version that it can be used with in the docs. If the user installs react, and then react-nested-router, all the require('react') calls in this library will resolve to the user-installed one.

If you want, you still could use peer deps. Just change the version to ">=0.10.0" instead of "^0.10.0" as stated in the original comment.

[mjackson]

Thanks for the explanation @jlongster. I think I get it now. :)

[jlongster]

Damn, that was fast :)

[ryanflorence]

when @jlongster starts using your library, there is no time for shenanigans.