Interface filters additional props when props contain a struct

[zaim]

Version: 3.2.11

As per documentation, an interface should not filter additional props unless strict = true. However, when an interface contains a struct member (or, I believe, when there are non-identity types), additional props do get filtered out.

Here's a minimal console.log test:

const t = require('tcomb')

const Point = t.struct({
  x: t.Number,
  y: t.Number
})

const PointInterface = t.inter({
  x: t.Number,
  y: t.Number
})

const HydrateInterface = t.inter({
  point: Point
})


console.log(PointInterface({
  x: 1,
  y: 2,
  extra: 3
}))

// Expected:
// { x: 1, y: 2, extra: 3 }
//
// Output (correct):
// { x: 1, y: 2, extra: 3 }


console.log(HydrateInterface({
  point: { x: 1, y: 2 },
  extra: 3
}))

// Expected:
// { point: Struct { x: 1, y: 2 }, extra: 3 }
//
// Output (incorrect):
// { point: Struct { x: 1, y: 2 } }
//
// The additional prop "extra" should not be filtered out

[zaim]

I believe this has to do with hydration and idempotency checking. If given an actual Point instance, it works as expected:

console.log(HydrateInterface({
  point: Point({ x: 1, y: 2 }),
  extra: 3
}))

// Output:
// { point: Struct { x: 1, y: 2 }, extra: 3 }

[gcanti]

@zaim thanks for the detailed report, going to fix this

[gcanti]

Should be fixed in https://github.com/gcanti/tcomb/releases/tag/v3.2.12