This repository has been archived by the owner on Feb 16, 2021. It is now read-only.
Fix: Enums.is() with an array value should always be false #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Javascript oddity: `true === {p: 'v'}.hasOwnProperty(['p'])`.
In ancient times, the checked value was also ensured to be a String.
This was removed with gcanti#94 (`Enums` supports numbers).
Note: With this fix, valid `Enums` values are restricted to the
officially supported types `Number` and `String`. The previous
implementation could have worked also for `Symbol`.
|
Thanks @phorsuedzie |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Javascript oddity:
true === {p: 'v'}.hasOwnProperty(['p']).In ancient times, the checked value was also ensured to be a String.
This was removed with #94 (
Enumssupports numbers).Note: With this fix, valid
Enumsvalues are restricted to theofficially supported types
NumberandString. The previousimplementation could have worked also for
Symbol.