Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug report: bcrypt version old #1853

Open
jonycoo opened this issue Jul 1, 2024 · 3 comments · May be fixed by #1857
Open

Bug report: bcrypt version old #1853

jonycoo opened this issue Jul 1, 2024 · 3 comments · May be fixed by #1857
Labels

Comments

@jonycoo
Copy link

jonycoo commented Jul 1, 2024

Describe the bug
The bcrypt library used in the code and on the website are incompatible with the new version of bcrypt. hashes generated from Cypershef begin with '$2a' they work, because bcrypt is backwards compatibel. the used bcrypt library has no update for the new version, hashes begin: '$2b' and can't generate or validate hashes generated with the new version.

To Reproduce
Steps to reproduce the behaviour or a link to the recipe / input used to cause the bug:

  1. Go to https://bcrypthashgenerator.tool-kit.dev/
  2. Enter a word (I used 'Hello')
  3. Click on 'wrench symbol' to generate the Hash
    (mine was '$2b$10$Du/WNkqlbIG.g4mgzbjHDuDf3v3JvMnDKzBAK3rI1TyyB5BxGqZYq' but yours will be different.
  4. Go to CyberChef
  5. Add 'Bcrypt compare' to a new/empty Recipe
  6. Enter your hash from the previouse generator tool in the Hash field of the Ingredient
  7. Enter the word used to generate the hash into the input field
  8. Bake
  9. It will output 'No match'

Expected behaviour
going throu the same steps as before should result in a positive match

Additional context
The used library of ChyberChef: 'bcryptjs' has not recived updates in the last seven years. The best alternative, which is also activly maintained is bcrypt

I'm not familiar with the structure of this project (haven't found a package.json) so i rather leave the implementation to someone else.

@jonycoo jonycoo added the bug label Jul 1, 2024
@shivansh84ya
Copy link

hi @jonycoo
could you assign this issue to me?

@shivansh84ya
Copy link

PR #1857

@jonycoo
Copy link
Author

jonycoo commented Jul 6, 2024

Thanks, sorry, I do not have the abitily to assign Issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants