Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Java 11 #194

Closed
t11947 opened this issue Aug 5, 2020 · 2 comments · Fixed by #239
Closed

Upgrade to Java 11 #194

t11947 opened this issue Aug 5, 2020 · 2 comments · Fixed by #239
Labels
dependencies Updates/changes to Maven or other dependencies enhancement Improvement to existing functionality/feature
Milestone
v2.0.0

Comments

@t11947
Copy link
Contributor

t11947 commented Aug 5, 2020 •
edited
Loading

Upgrading Koryphe to Java 11 will allow us to keep up with the Java LTS version and leverage some of the new features in post-Java 8 versions such as better integration with container technologies, the JShell and new language features.

Modularisation of Koryphe is not in scope for this ticket. A new ticket will be raised for this once the upgrade has occurred.

Related to Gaffer issue: gchq/Gaffer#2300
@t11947 t11947 added the enhancement Improvement to existing functionality/feature label Aug 5, 2020
t11947 added a commit that referenced this issue Aug 27, 2020
@t11947
Merge pull request #196 from phosphorbronze50/develop
696cb86 
Changes for Upgrade to Java 11 #194
t11947 added a commit that referenced this issue Aug 27, 2020
@t11947
Revert "Changes for Upgrade to Java 11 #194"
26ffa1b
@n3101 n3101 added this to the v2.0.0 milestone May 12, 2021
@n3101
Copy link

n3101 commented May 12, 2021

PR #196 was applied and then reverted as being a breaking change. The PR has been closed but I don't think it was ever applied to the v2_develop branch, which is where it belongs. This needs checking.

@n3101
Copy link

n3101 commented Jun 8, 2021 •
edited
Loading

This code was merged by #198 into a "develop 2.0" branch, but that no longer exists, so effectively this has NOT been merged . Thanks to @r32575 for looking into this.

A new PR is required.

@n3101 n3101 added the dependencies Updates/changes to Maven or other dependencies label Nov 17, 2021
t511203 added a commit that referenced this issue Jan 24, 2022
@t511203
gh-194: Migrate koryphe to Java 11.
19e71e5
t511203 added a commit that referenced this issue Jan 24, 2022
@t511203
gh-194: Migrate koryphe to Java 11.
69336de
t511203 added a commit that referenced this issue Jan 24, 2022
@t511203
gh-194: Migrate koryphe to Java 11.
0047f03
@github-actions github-actions bot mentioned this issue Jan 24, 2022
Merged
t511203 added a commit that referenced this issue Jan 24, 2022
@t511203
gh-194: Migrate koryphe to Java 11.
b66f13e
t511203 added a commit that referenced this issue Jan 25, 2022
@t511203
Merge branch 'develop' into gh-194-update-to-java-11
5d1e6c7
t92549 added a commit that referenced this issue Feb 3, 2022
@t92549
Merge branch 'develop' into gh-194-update-to-java-11
5463b94
t511203 added a commit that referenced this issue Feb 7, 2022
@t511203
gh-194: Fix imports and change usages of requireNonNullOrElseGet to r…
38b3957 
…equireNonNullElse.
t511203 added a commit that referenced this issue Feb 7, 2022
@t511203
gh-194: Fix headers.
2686399
t92549 added a commit that referenced this issue Feb 10, 2022
@t511203 @t92549
gh-194: Migrate koryphe to Java 11. (#239)
e04797e 
* gh-194: Migrate koryphe to Java 11.

* gh-194: Fix imports and change usages of requireNonNullOrElseGet to requireNonNullElse.

* gh-194: Fix headers.

Co-authored-by: t511203 <t511203@users.noreply.github.com>
Co-authored-by: t92549 <80890692+t92549@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Updates/changes to Maven or other dependencies enhancement Improvement to existing functionality/feature
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

gh-194: Migrate koryphe to Java 11. gchq/koryphe
2 participants
@n3101 @t11947