Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChainedIterable Duplicate Class #266

Closed
GCHQDev404 opened this issue May 6, 2022 · 1 comment · Fixed by #267
Closed

ChainedIterable Duplicate Class #266

GCHQDev404 opened this issue May 6, 2022 · 1 comment · Fixed by #267
Labels
enhancement Improvement to existing functionality/feature
Milestone
v2.2.0

Comments

@GCHQDev404
Copy link
Contributor

linked to : ChainedIterable Duplicated Classes. #2369

Make ChainedIterable public
GCHQDev404 added a commit that referenced this issue May 6, 2022
@GCHQDev404
gh-266 ChainedIterable made public
f88383a
@t92549 t92549 added the enhancement Improvement to existing functionality/feature label May 6, 2022
@t92549 t92549 added this to the v2.2.0 milestone May 6, 2022
@t92549
Copy link
Contributor

t92549 commented May 6, 2022

To fix the issue of duplicating the ChainedIterable class between koryphe and Gaffer, they should be made public in koryhpe. Then they can be removed from Gaffer, replacing all Gaffer references to the public koryphe version: gchq/Gaffer#2369.

GCHQDev404 added a commit that referenced this issue May 6, 2022
@GCHQDev404
Merge branch 'develop' into gh-266-chainediterable-public
2262bf9
@github-actions github-actions bot mentioned this issue May 6, 2022
Merged
GCHQDev404 added a commit that referenced this issue May 6, 2022
@GCHQDev404
gh-266 ChainedIterable made public - typo
777631d
GCHQDev404 added a commit that referenced this issue May 6, 2022
@GCHQDev404
gh-266 ChainedIterable made public - typo
287f28b
t92549 added a commit that referenced this issue May 6, 2022
@t92549
Merge branch 'develop' into gh-266-chainediterable-public
2e4bcf0
t92549 added a commit that referenced this issue May 6, 2022
@t92549
gh-266: Moved out all Iterable classes into iterable module
8d47243
t92549 added a commit that referenced this issue May 6, 2022
@t92549
Merge branch 'develop' into gh-266-chainediterable-public
fa81d5a
t92549 added a commit that referenced this issue May 6, 2022
@t92549
gh-266: Spotless apply
12804ca
t92549 added a commit that referenced this issue May 6, 2022
@t92549
gh-266: Added more iterable tests
f3af34c
t92549 added a commit that referenced this issue May 6, 2022
@t92549
gh-266: Cleanup and add more constructors
ee5ca25
t92549 added a commit that referenced this issue May 6, 2022
@t92549
gh-266: Tidy up null check on list
4445d43
t92549 added a commit that referenced this issue May 6, 2022
@GCHQDev404 @t92549
gh-266 ChainedIterable made public (#267)
02865ed 
* gh-266 ChainedIterable made public

* gh-266 ChainedIterable made public - typo

* gh-266: Moved out all Iterable classes into iterable module

* gh-266: Spotless apply

* gh-256: Moved over constructors and tests from Gaffer

* gh-266: Added more iterable tests

* gh-266: Cleanup and add more constructors

* gh-266: Tidy up null check on list

Co-authored-by: GCHQDev404 <GCHQDev404@users.noreply.github.com>
Co-authored-by: t92549 <80890692+t92549@users.noreply.github.com>
@t92549 t92549 mentioned this issue May 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement to existing functionality/feature
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging a pull request may close this issue.

gh-266 ChainedIterable made public gchq/koryphe
2 participants
@GCHQDev404 @t92549