Skip to content

Commit

Permalink
Bug fix to prevent packet list search not returning
Browse files Browse the repository at this point in the history
The symptom is that the spinner stays active. When the packet list
search wraps, it mistakenly moves back to packet 1 to resume the
search. But if a display filter is applied, packet 1 may not be
loaded. The search implementation will make a request to the loader to
load packet 1, but the loader ignores it because as far as it's
concerned, the first block of packets have been loaded in their
entirety; they just don't include packet 1 because it doesn't match the
display filter. This procedure repeated indefinitely. The fix is to loop
back to the first packet loaded.
  • Loading branch information
gcla committed Jul 10, 2022
1 parent 559e412 commit 79fad3d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ui/searchpktlist.go
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ Loop:
// 32, 44, 45, 134, 209,...
curPacketNumber, ok = Loader.PacketNumberOrder[curPacketNumber]
if !ok {
curPacketNumber = 1
curPacketNumber = Loader.PacketNumberOrder[0]
}
Loader.PsmlLoader.Unlock()

Expand Down

0 comments on commit 79fad3d

Please sign in to comment.