-
Notifications
You must be signed in to change notification settings - Fork 411
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This change makes the Help dialogs and the new Columns dialog properly modal. This has the effect of preventing the 'q' key from bringing up the "quit termshark" dialog while either of these two dialog instances are open. The former behavior causes a bug because termshark needs to close the Columns dialog in order to trigger the termination of some goroutines associated with the dialog's tshark filter validators, and quitting via 'q' leaves the Columns dialog open. Termshark, by default, will not terminate unless it has ensured all its goroutines have stopped (to prevent leaks via behavior that is buggy but that I don't necesarily detect otherwise).
- Loading branch information
Showing
4 changed files
with
6 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters