fix: react: ignore react in production build to avoid conflicts (Eigh…

…tfoldAI#29) * fix: react: ignore react in production build to avoid conflicts * chore: version: bump version in package json * chore: npm: updates npm ignore
gclark-eightfold · Apr 27, 2022 · 4d19101 · 4d19101
1 parent 5a9b00f
commit 4d19101
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 6 deletions.
diff --git a/packages/octuple/.npmignore b/packages/octuple/.npmignore
@@ -14,7 +14,9 @@ npm-debug.log*
 README.md
 stats.json
 tsconfig.json
-webpack.config.js
+webpack.common.js
+webpack.dev.js
+webpack.prod.js
 yarn.lock
 yarn-debug.log*
 yarn-error.log*
@@ -28,5 +30,6 @@ yarn-error.log*
 .env.local
 .env.production.local
 .env.test.local
+.versionrc.json
 
 lib/octuple.js.LICENSE.txt
diff --git a/packages/octuple/package.json b/packages/octuple/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@eightfold.ai/octuple",
-    "version": "0.0.2",
+    "version": "0.0.3",
     "license": "MIT",
     "main": "lib/octuple.js",
     "types": "lib/octuple.d.ts",

diff --git a/packages/octuple/webpack.prod.js b/packages/octuple/webpack.prod.js
@@ -5,9 +5,13 @@ process.env.NODE_ENV = 'production';
 
 module.exports = {
     ...WebpackCommonConfig,
+    externals: {
+        react: 'commonjs react',
+        'react-dom': 'commonjs react-dom',
+    },
     plugins: [
         new webpack.DefinePlugin({
-            VERSION: JSON.stringify(require('./package.json').version)
-        })
-    ]
-};
+            VERSION: JSON.stringify(require('./package.json').version),
+        }),
+    ],
+};