Fixes #8 : special characters in username

gclem · Jul 3, 2017 · 1ae6fec · 1ae6fec
1 parent 43f8ce6
commit 1ae6fec
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/lib/overwatch.js b/lib/overwatch.js
@@ -82,11 +82,11 @@ let OverwatchProvider = function () {
                 break;
         }
 
-        return url + `${platform}${region}/${tag}`;
+        return url + `${platform}${region}/${encodeURIComponent(tag)}`;
     };
 
     let getSearchUrl = (nickname) => {
-        return searchUrl + nickname;
+        return searchUrl + encodeURIComponent(nickname);
     };
 
     let parseSeason = (url) => {
@@ -203,13 +203,10 @@ let OverwatchProvider = function () {
         switch (err.response.statusCode) {
             case 404:
                 throw new Error('PROFILE_NOT_FOUND');
-                break;
             case 500:
                 throw new Error('TECHNICAL_EXCEPTION_HTML_STRUCTURE_MAY_HAVE_CHANGED')
-                break;
             default:
                 throw new Error('TECHNICAL_EXCEPTION_NOT_IDENTIFIED')
-                break;
         }
     }
 
@@ -218,6 +215,7 @@ let OverwatchProvider = function () {
     }
 
     self.getAll = (platform, region, tag, overallOnly) => {
+        //tag = unescape(tag);
         var baseurl = getUrl(platform, region, tag);
         return rp(baseurl).then((context) => {
 

diff --git a/specs/mocktest.js b/specs/mocktest.js
@@ -3,8 +3,12 @@
 
 var ow = require('../index.js');
 
-ow.search('Zeya-2303')
+ow.search('SĔNPAI-1698')
     .then((data) => console.dir(data, {depth : 3, colors : true}) );
 
 ow.getAll('pc', 'eu', 'Zeya-2303')
     .then((data) => console.dir(data, {depth : 2, colors : true}) );
+
+//// Special characters
+ow.getAll('pc', 'us', 'SĔNPAI-1698')
+    .then((data) => console.dir(data, {depth : 2, colors : true}) );