Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove eat-reload workaround #160

Closed
wants to merge 1 commit into from

Conversation

rossviljoen
Copy link

I believe this workaround is no longer necessary after this change.

@gcv
Copy link
Owner

gcv commented Aug 12, 2024

Are you sure? I tried to start Eat with that change, and it still managed to hang in a fresh Emacs session. Eat 0.9.4 from MELPA Stable. Then I put the workaround back in the Eat configuration, and it worked. Then I your change back in, and it worked.

@rossviljoen
Copy link
Author

Strange, in a fresh emacs 29.4 with the following init.el it works fine (installing Eat 0.9.4 from NonGNU ELPA):

(require 'package)
(when (not package-archive-contents)
    (package-refresh-contents))
(package-initialize)

(use-package eat
  :ensure t
  :pin nongnu
  :custom
  (eat-kill-buffer-on-exit t)
  :config
  (delete [?\C-u] eat-semi-char-non-bound-keys) ; make C-u work in Eat terminals like in normal terminals
  (delete [?\C-g] eat-semi-char-non-bound-keys) ; ditto for C-g
  (eat-update-semi-char-mode-map)
  (eat-reload))

but if it's still an issue feel free to close the PR

@gcv
Copy link
Owner

gcv commented Aug 16, 2024

I just double-checked. After removing the workaround, it looks like Eat does start after a pause, but still does something strange. I get this *Warnings* buffer:

Error (use-package): eat/:config: Lisp nesting exceeds ‘max-lisp-eval-depth’

Do you get this? This happens on Mac and Linux, both running Emacs 29.4.

@gcv
Copy link
Owner

gcv commented Sep 13, 2024

I think the workaround is still needed, please reopen if I’m wrong.

@gcv gcv closed this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants