-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sword-api): get_service_document throws error due to auth-failure #163
base: main
Are you sure you want to change the base?
fix(sword-api): get_service_document throws error due to auth-failure #163
Conversation
@jmurugan-fzj thanks for the pull request! I wish we had some CI set up to test pyDataverse regularly. That way we could include in pull requests like this some tests asserting that the service document can be retrieved. Would you be interested in helping with this effort? We're spinning up Dataverse in GitHub Actions over at https://github.com/gdcc/api-test-runner and plan to someday create a proper GitHub Action: https://github.com/gdcc/dataverse-action I just opened this related issue: |
@pdurbin yes sure, I can also support but may not be able to guarantee the priority for this task presently with my work related engagements, may be we could discuss further your expectations regarding my contributions? |
Yes, it would be great to talk. Maybe next week? I'm hoping to know more about the pyDataverse situation on Monday. |
@pdurbin Sure, could you please send me an invite for next week? I am available most days after Monday and my time zone is GMT+1 |
@jmurugan-fzj are you on Zulip? @JR-1991 and I talk in #python there. We just advertised this in the README: You're very welcome to join us! Maybe there we could figure out a meeting time. |
@pdurbin Thanks, I joined and messaged you there, let me know your availability! |
@jmurugan-fzj thanks for the submission! I tested your PR to from easyDataverse import Dataverse
# Connect to a Dataverse installation
dataverse = Dataverse(
server_url="https://demo.dataverse.org",
api_token="...",
)
# Intiialize a dataset
dataset = dataverse.create_dataset()
# Fill metadata blocks
dataset.citation.title = "My dataset"
dataset.citation.subject = ["Other"]
dataset.citation.add_author(name="John Doe")
dataset.citation.add_dataset_contact(name="John Doe", email="john@doe.com")
dataset.citation.add_ds_description(value="This is a description of the dataset")
dataset.upload("ed_test")
response = dataverse.native_api.create_dataset(
"ed_test",
dataset.dataverse_json(),
)
print(response.text) Out
|
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Describe your environment
Follow best practices
Describe the PR
Closes #ISSUE_NUMBER
to the end of this pull requestTesting
Commits
Closes #ISSUE_NUMBER
in your commit messages to auto-close the issue that it fixes (if such).Others
Documentation contribution
Code contribution
Closes #162