Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add names to test manifests #112

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Add names to test manifests #112

merged 1 commit into from
Nov 14, 2024

Conversation

eerii
Copy link

@eerii eerii commented Nov 14, 2024

When using system-deps as a git or local dependency instead of the version from crates.io, cargo generates errors because the Cargo.toml files from the tests don't have the name field, even if they are not real manifests. It still compiles, but the output is very verbose and it could be misleading.

error: missing field `name`
 --> ../../../.cargo/git/checkouts/system-deps-3c68ab912ff25118/6fcbb37/src/tests/toml-fallback-names/Cargo.toml:1:2
  |
1 | [package.metadata.system-deps.test_lib]
  |  ^^^^^^^
  |
... (many lines like this)

This PR just adds the field to the existing manifest with the same name as the test. This shouldn't have any other effects than removing the warnings.

Tested with cargo 1.82.0 (8f40fc59f 2024-08-21)

@gdesmott
Copy link
Owner

@eerii can you please rebase your branch? I'd like to check if my commit fixed the coverage CI but it seems there is no easy way to rebase directly from github...

@eerii
Copy link
Author

eerii commented Nov 14, 2024

Absolutely c:

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.91%. Comparing base (0cfb6ee) to head (bc91a43).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #112   +/-   ##
=======================================
  Coverage   90.91%   90.91%           
=======================================
  Files           3        3           
  Lines        2257     2257           
=======================================
  Hits         2052     2052           
  Misses        205      205           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdesmott gdesmott merged commit 38acdbc into gdesmott:main Nov 14, 2024
9 checks passed
@gdesmott
Copy link
Owner

Thanks for the patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants