Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to TypeScript #779

Merged
merged 1 commit into from
Apr 3, 2020
Merged

Convert to TypeScript #779

merged 1 commit into from
Apr 3, 2020

Conversation

abraham
Copy link
Member

@abraham abraham commented Mar 23, 2020 •
edited
Loading

Closes #580.

Convert the front-end app to TypeScript.

  • Convert all the src files to TypeScript
  • Switch from polymer-redux to pwa-helpers
    • mapStateToProps to stateChanged
    • this.dispatchAction to store.dispatch
  • Define private class properties for polymer properties.

I tried using @polymer/decorators but there was issues with state change not being triggered sometimes. Decorators can be applied in #796.

Currently deployed to https://hoverboard-dev.firebaseapp.com/

@abraham abraham marked this pull request as ready for review March 30, 2020 03:31
@abraham abraham requested a review from pearlbea March 30, 2020 03:31
@abraham abraham mentioned this pull request Apr 2, 2020
Merged
@abraham abraham merged commit f664bef into gdg-x:master Apr 3, 2020
@abraham abraham deleted the typescript branch April 3, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pearlbea pearlbea Awaiting requested review from pearlbea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch to TypeScript
1 participant
@abraham