Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: EntryID and cron.nextID renaming #12

Merged
merged 3 commits into from
Nov 6, 2023

Conversation

janrnc
Copy link
Member

@janrnc janrnc commented Sep 14, 2023

  • Renamed EntryID to ID. It identifies the main concept of a scheduled job and does not need an Entry prefix IMO.
  • Renamed cron.nextID to cron.next. It's a variable of type ID and therefore this information does not necessarily need to be repeated.
  • cron.next now contains the next value to be used, not the last used one.

@janrnc janrnc changed the title testing semantic PR workflow refactor: EntryID and cron.nextID renaming Sep 14, 2023
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #12 (9a2984f) into master (5eb0ef7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #12   +/-   ##
=======================================
  Coverage   96.66%   96.66%           
=======================================
  Files           7        7           
  Lines         659      660    +1     
=======================================
+ Hits          637      638    +1     
  Misses         18       18           
  Partials        4        4           
Files Changed Coverage Δ
cron.go 95.74% <100.00%> (+0.02%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@janrnc janrnc changed the title refactor: EntryID and cron.nextID renaming feat: EntryID and cron.nextID renaming Sep 15, 2023
@janrnc janrnc merged commit 6e9e3a0 into gdgvda:master Nov 6, 2023
6 of 7 checks passed
Copy link

🎉 This PR is included in version 0.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@janrnc janrnc deleted the refactor/entry-id-renaming branch September 10, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant