Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes, update on ArticleController #91

Merged
merged 2 commits into from
Dec 10, 2023
Merged

Minor fixes, update on ArticleController #91

merged 2 commits into from
Dec 10, 2023

Conversation

sxergiu
Copy link
Contributor

@sxergiu sxergiu commented Dec 10, 2023

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Change (fix or feature that would cause existing functionality to not work as expected)

Tested?

Have you tested your code?

  • Yes
  • No

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link

Test Run for PR #91 (272)

Run Summary

Overall Result: ✔️ Pass
Pass Rate: 100%
Run Duration: 1s 622ms
Date: 2023-12-10 18:52:16 - 2023-12-10 18:52:17
Framework: .NETCoreApp,Version=v8.0
Total Tests: 28

✔️ Passed ❌ Failed ⚠️ Skipped
28 0 0
100% 0% 0%

Result Sets

GdscBackend.Tests.dll - 100%

Full Results
Result Test Duration
✔️ Passed GdscBackend.Tests.MembersControllerTests.Get_Returns_Member_by_ID 547ms
✔️ Passed GdscBackend.Tests.MenuItemsControllerTests.Delete_Returns404NotFoundResult 782ms
✔️ Passed GdscBackend.Tests.SettingsControllerTests.Get_ReturnsAllExamples 786ms
✔️ Passed GdscBackend.Tests.ExampleTests.Get_ReturnsAllExamples 791ms
✔️ Passed GdscBackend.Tests.MembersControllerTests.Get_Should_Return_All_Members 38ms
✔️ Passed GdscBackend.Tests.MenuItemsControllerTests.Post_ReturnsCreatedObject 48ms
✔️ Passed GdscBackend.Tests.ExampleTests.Post_ReturnsCreatedObject 35ms
✔️ Passed GdscBackend.Tests.SettingsControllerTests.Post_ReturnsCreatedObject 44ms
✔️ Passed GdscBackend.Tests.MembersControllerTests.Delete_Should_Delete_Member_By_ID 14ms
✔️ Passed GdscBackend.Tests.MenuItemsControllerTests.GetById_ReturnsOkObjectResult 9ms
✔️ Passed GdscBackend.Tests.MembersControllerTests.Post_ReturnsCreatedObject 22ms
✔️ Passed GdscBackend.Tests.TechnologiesControllerTests.Post_ReturnsCreatedObject 58ms
✔️ Passed GdscBackend.Tests.MenuItemsControllerTests.Update_ReturnsOkObjectAction 74ms
✔️ Passed GdscBackend.Tests.TechnologiesControllerTests.Get_ReturnsAllTechnologies 22ms
✔️ Passed GdscBackend.Tests.MenuItemsControllerTests.Get_ReturnsAllExamples 13ms
✔️ Passed GdscBackend.Tests.ContactsControllerTests.Delete_Multiple_Contacts 84ms
✔️ Passed GdscBackend.Tests.TechnologiesControllerTests.Delete_ReturnsOkResult 33ms
✔️ Passed GdscBackend.Tests.EventsControllerTests.Delete_ReturnOkObjectResult 120ms
✔️ Passed GdscBackend.Tests.ContactsControllerTests.Get_Should_Return_All_Contacts 22ms
✔️ Passed GdscBackend.Tests.TeamsControllerTests.Get_ReturnsAllExamplesById 48ms
✔️ Passed GdscBackend.Tests.ContactsControllerTests.Post_ReturnsCreatedObject 11ms
✔️ Passed GdscBackend.Tests.FilesControllerTests.Upload_ShouldReturnFilePaths 972ms
✔️ Passed GdscBackend.Tests.TeamsControllerTests.Post_ReturnsCreatedObject 9ms
✔️ Passed GdscBackend.Tests.ContactsControllerTests.Delete_Should_Delete_Contact_By_ID 15ms
✔️ Passed GdscBackend.Tests.EventsControllerTests.Post_ReturnsCreatedEventObject 30ms
✔️ Passed GdscBackend.Tests.TeamsControllerTests.Delete_Returns_OkResult 12ms
✔️ Passed GdscBackend.Tests.TeamsControllerTests.Get_ReturnsAllExamples 9ms
✔️ Passed GdscBackend.Tests.EventsControllerTests.Update_ReturnOKObjectResult 24ms

Run Messages

Informational

[xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.5.5+28b46ff510 (64-bit .NET 8.0.0)
[xUnit.net 00:00:00.07]   Discovering: GdscBackend.Tests
[xUnit.net 00:00:00.10]   Discovered:  GdscBackend.Tests
[xUnit.net 00:00:00.10]   Starting:    GdscBackend.Tests
[xUnit.net 00:00:01.17]   Finished:    GdscBackend.Tests
Warning

Error


Created using Liquid Test Reports

@danpercic86 danpercic86 merged commit 9d09176 into main Dec 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants