Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add drc counter #280

Merged
merged 4 commits into from
Dec 15, 2023
Merged

Add drc counter #280

merged 4 commits into from
Dec 15, 2023

Conversation

joamatab
Copy link
Contributor

@joamatab joamatab commented Dec 15, 2023 •
edited
Loading

Saves a DRC report in YAML

works on a folder or a single .rdb file

@HelgeGehring
@simbilod
@nikosavola
@tvt173

nikosavola
nikosavola approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@nikosavola nikosavola left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🚀😃

Ideally there would also be a test but this is fine.

@joamatab
Copy link
Contributor Author

yes, a test and CLI would be great for this

I also added a total entry

@joamatab joamatab mentioned this pull request Dec 15, 2023
Open
@joamatab joamatab merged commit 97b5324 into main Dec 15, 2023
13 checks passed
@joamatab joamatab deleted the add_drc_counter branch December 15, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikosavola nikosavola nikosavola approved these changes

@HelgeGehring HelgeGehring Awaiting requested review from HelgeGehring

@simbilod simbilod Awaiting requested review from simbilod

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joamatab @nikosavola